4/10/2023 0 Comments Eclipse json compare view color![]() I only know of the public update site and some guides on how to extend it which mainly deal with the backend rest framework on the application server though. As far as I know there is no source code publicly available. I suppose it might be hardcoded against the standard dark theme name in the worst case scenario. Hmm, I vaguely recall an ADT update where the release notes specified better dark theme support. However, I don't think that's the issue here. It's possible that ADT provides it's own additional dark theme CSS to Eclipses dark theme, as was the case for Eclemma. I wanted to check out the source code for ADT but was having trouble finding it (though I checked very quickly). If we find the source code for ADT, I should be able to fix that for you :) I imagine this is ABAP code that isin't themed correctly? Maybe the developpers of Darkest Dark theme patched the classes responsible for table views such as the properties view to disable these do you have any thoughts on the above? Maybe an upstream patch could be made to allow tLinesVisible() through Eclipse CSS? I'm not sure yet if this would be possible but it seems like an interesting idea. I suspect that the properties view calls tLinesVisible(true) and unfortunately, I don't think I can disable this through Eclipse's CSS theming. I recall realizing that if you create a table in SWT (which is used for Eclipse's GUI) and call tLinesVisible(true), it adds those displeasing white lines in the table when using a dark theme on Windows. I wasn't aware of this and am happy you brought it to my attention. ![]() When you say "white borders" I assume you're reffering to the white lines which divide the table's rows/columns correct? It's more likely that this is just a Windows specific issue however. I currently suspect the issue is either occuring on all installs of Spectrum Theme on Windows or occuring when Spectrum Theme is installed with ABAP Development Tools (on Windows specifically?). I'm going to check it out on Windows shortly and see how it looks there for me. I quickly checked out the properties view on Linux in my current Eclipse installation, and things seem to look OK: Thankfully, my university's reading week is this week, so I'm gonna try and have this fixed this week :) I just need to do a bit more investigation. Unfortunately there are some glaring white spots. I'm happy to be able to provide an OSS alternative to Darkest Dark/DevStyle :) Hi, I was looking for an alternative to Darkest Dark (because of it being very heavy with additional stuff I don't want and commercial licensing) and found your theme. I looked through the windows tag but have not seen these issues reported Thank you for the wonderful bug report, this is the type of bug ticket every OSS maintainer hopes for :) The code itself is also entirely not color themed but I am fairly certain that's because the ABAP Development Tools are using their own color variables. The default dark theme has these as well:ĭarkest Dark has solved this somehow. This is a fresh Eclipse installation and workspace. ![]() Spectrum Theme 1.09070230 installed using the marketplace.ABAP Development Tools for Eclipse (ADT) 3.12.5. ![]() ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |